Feature Request: Add regex filtering to topic like we do in groups. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgeller
requested changes
Jan 29, 2018
There was a problem hiding this comment.
@michaelritsema sorry for the delay and thank you very much for the PR!
generally looks like a nice improvement to me, would prefer more explicit names though. let me know what you think and if you have time for it or if you'd prefer me to merge and apply the changes myself.
| @@ -420,6 +431,7 @@ func (cmd *groupCmd) parseFlags(as []string) groupArgs { | |||
| flags.StringVar(&args.brokers, "brokers", "", "Comma separated list of brokers. Port defaults to 9092 when omitted (defaults to localhost:9092).") | |||
| flags.StringVar(&args.group, "group", "", "Consumer group name.") | |||
| flags.StringVar(&args.filter, "filter", "", "Regex to filter groups.") | |||
| flags.StringVar(&args.tfilter, "tfilter", "", "Regex to filter topics.") | |||
There was a problem hiding this comment.
@michaelritsema i'd prefer a more explicit flag & var name. e.g. filter-topic and filter-group - what do you think?
|
will fix this on master - cheers @michaelritsema |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not familiar with your codebase. I'm using this branch because I needed topic filtering (I have thousands).